This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Import file of usernames to provide private project access#773
Open
ethan-nelson wants to merge 1 commit intohotosm:masterfrom
Open
Import file of usernames to provide private project access#773ethan-nelson wants to merge 1 commit intohotosm:masterfrom
ethan-nelson wants to merge 1 commit intohotosm:masterfrom
Conversation
ethan-nelson
changed the title
Collaborator
Author
|
Since this is a javascript implementation, I wasn't able to figure out a way to write it into automated tests. Someone else will need to test it out on their machine to make sure it's 🆗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #760 by providing an interface to upload a file of usernames and give them access for private projects. The file can be comma separated, line separated, or a mixture of those. This doesn't add new users to the TM database, however. If a username supplied is not in the TM system, it will throw a 500 error for that name (shows up in console.log) and continue.
My javascripting probably isn't the neatest, so feedback is especially welcome on that. Tests are incoming.