Fixes post processing. Add more detailed stats for custom exports. #293
Merged
kshitijrajsharma merged 4 commits intodevelopfrom Mar 13, 2025
Merged
Fixes post processing. Add more detailed stats for custom exports. #293kshitijrajsharma merged 4 commits intodevelopfrom
kshitijrajsharma merged 4 commits intodevelopfrom
Conversation
…ats for custom exports. Disable transliterations for now
Contributor
Author
|
@kshitijrajsharma tests were failing for this PR before but now all passed, it seems it was a broken service (Kontur stats?) |
kshitijrajsharma
approved these changes
Mar 12, 2025
kshitijrajsharma
approved these changes
Mar 12, 2025
Member
|
You should also remove osm_type I think it would be redundant too ! |
Contributor
Author
✅ Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do ?
Fixes wrong stats
There are two issues currently with stats generation:
For example here total number of features should be
450297,highwaypercentage should be100%and nobuildingshould be there:This is fixed in this PR, simplifying the way geojson_stats is being used.
Add more detailed HTML stats for custom exports
For Buildings, Roads, Highways, Waterways and Railways more detailed stats were added, including the values for the corresponding tag, for example waterways:
Also the languages list was added and
osm_idandTotal featureswere removed because those are redundant.Disable transliterations for now
Transliterations were not enabled in production. This feature was disabled for now, to not interfere with stats generation (as both are part of the post-processing feature) and will be added later.
How to test ?
Generate a custom export and check if the stats results are correct.