Ci/feat/terragrunt multi module#6738
Merged
nischalstha9 merged 8 commits intotasking-manager-fastapifrom Mar 6, 2025
Merged
Conversation
nischalstha9
force-pushed
the
ci/feat/terragrunt-multi-module
branch
from
ec008a6 to
ad521bf
Compare
prabinoid
force-pushed
the
tasking-manager-fastapi
branch
from
044c3bc to
1b9e707
Compare
Member
|
Huge number of merge conflicts here that will make it difficult for me to review. Can we also discuss over a call the background of this PR and intentions for merging into the fastapi branch? |
nischalstha9
force-pushed
the
ci/feat/terragrunt-multi-module
branch
from
042a58b to
e0c5725
Compare
Contributor
Author
|
@dakotabenjamin I have rebased and now there are only changes that need review. |
dakotabenjamin
requested changes
Feb 18, 2025
Member
dakotabenjamin
left a comment
dakotabenjamin
left a comment
There was a problem hiding this comment.
Looks good! Just needs two small changes.
nischalstha9
force-pushed
the
ci/feat/terragrunt-multi-module
branch
from
e0c5725 to
c24266e
Compare
nischalstha9
force-pushed
the
ci/feat/terragrunt-multi-module
branch
from
c24266e to
cdb0eb6
Compare
nischalstha9
force-pushed
the
ci/feat/terragrunt-multi-module
branch
from
cdb0eb6 to
738afc8
Compare
nischalstha9
had a problem deploying
to
staging
GitHub Actions
Failure
nischalstha9
had a problem deploying
to
staging
GitHub Actions
Failure
nischalstha9
had a problem deploying
to
staging
GitHub Actions
Failure
nischalstha9
had a problem deploying
to
staging
GitHub Actions
Failure
nischalstha9
force-pushed
the
tasking-manager-fastapi
branch
from
4ccfbc5 to
044c3bc
Compare
nischalstha9
force-pushed
the
ci/feat/terragrunt-multi-module
branch
3 times, most recently
from
4956136 to
d41c12e
Compare
nischalstha9
force-pushed
the
ci/feat/terragrunt-multi-module
branch
from
cfb2b66 to
f2498b5
Compare
for more information, see https://pre-commit.ci
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
This PR adds feature to run terragrunt workflow on different directory with environment based plan and apply stage and GH review based deployment for security purpose.
You can run plan workflow on following modules and after it success, it will auto trigger apply module:
This PR too adds feature of review based deployment utilizing GitHub Environments. The plan and apply stage are on separate workflow. When the plan workflow (
terragrunt plan) completes with review, the apply workflow runs automatically and waits for review to runterragrunt apply.Closes #6739
Fixes: #6774