Skip to content

Update task stats project dict changed to record object #6797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nischalstha9 merged 1 commit into from
Apr 2, 2025
Merged

Update task stats project dict changed to record object #6797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions backend/services/stats_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,18 +80,17 @@ async def _update_tasks_stats(
db: Database,
action="change",
):
project_stats = dict(project) # Mutable copy of the project dictionary
if new_state == last_state:
return project_stats, user
return project, user

# Increment counters for the new state
if new_state == TaskStatus.MAPPED:
project_stats["tasks_mapped"] += 1
project.tasks_mapped += 1

elif new_state == TaskStatus.VALIDATED:
project_stats["tasks_validated"] += 1
project.tasks_validated += 1
elif new_state == TaskStatus.BADIMAGERY:
project_stats["tasks_bad_imagery"] += 1
project.tasks_bad_imagery += 1

# Increment user stats if action is "change"
if action == "change":
Expand All @@ -104,12 +103,12 @@ async def _update_tasks_stats(

# Decrement counters for the old state
if last_state == TaskStatus.MAPPED:
project_stats["tasks_mapped"] -= 1
project.tasks_mapped -= 1
elif last_state == TaskStatus.VALIDATED:
project_stats["tasks_validated"] -= 1
project.tasks_validated -= 1

elif last_state == TaskStatus.BADIMAGERY:
project_stats["tasks_bad_imagery"] -= 1
project.tasks_bad_imagery -= 1

# Undo user stats if action is "undo"
if action == "undo":
Expand All @@ -130,10 +129,10 @@ async def _update_tasks_stats(
WHERE id = :project_id
""",
values={
"tasks_mapped": project_stats["tasks_mapped"],
"tasks_validated": project_stats["tasks_validated"],
"tasks_bad_imagery": project_stats["tasks_bad_imagery"],
"project_id": project_stats["id"],
"tasks_mapped": project.tasks_mapped,
"tasks_validated": project.tasks_validated,
"tasks_bad_imagery": project.tasks_bad_imagery,
"project_id": project.id,
},
)

Expand All @@ -152,7 +151,7 @@ async def _update_tasks_stats(
"user_id": user.id,
},
)
return project_stats, user
return project, user

@staticmethod
async def get_latest_activity(
Expand Down