Skip to content

Fix extra iD URL parameter offset not working for custom imagery issue#6950

Merged
ramyaragupathy merged 2 commits intodevelopfrom
fix/6676-additional-id-url-param-issue
Nov 20, 2025
Merged

Fix extra iD URL parameter offset not working for custom imagery issue#6950
ramyaragupathy merged 2 commits intodevelopfrom
fix/6676-additional-id-url-param-issue

Conversation

@royallsilwallz
Copy link
Copy Markdown
Contributor

@royallsilwallz royallsilwallz commented Jul 19, 2025

What type of PR is this?

  • 🐛 Bug Fix

Related Issue

Describe this PR

This PR fixes the extraIdParams in URL parameters not populating in iD editor for custom imagery.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 19, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@manjitapandey
Copy link
Copy Markdown

manjitapandey commented Aug 4, 2025 •
edited
Loading

When the offset value is changed, the first values are stored and visualised even for different projects. (something like caching behavior)
This behavior is very irregular. Will update when I could have proper replication steps here.

Edit:
When I select a project with offset and go to ID editor, the offset is correct and functional.
When I select second project and go to id editor, the offset shows the offset of first project. - Not expected
When I refresh ID editor page, and check the offset, its still incorrect and shows offset of first project. - Not expected.
When I go to project details page or tasks page and refresh and get to ID editor page, the offset is updated for that project. Correct and expected.

cc: @ramyaragupathy , @royallsilwallz

@royallsilwallz royallsilwallz force-pushed the fix/6676-additional-id-url-param-issue branch from f5f42df to d5794cf Compare October 11, 2025 05:03
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 11, 2025

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@royallsilwallz
Copy link
Copy Markdown
Contributor Author

royallsilwallz commented Oct 11, 2025 •
edited
Loading

@manjitapandey I've pushed the fixes !
Let me know if any more issue arises.
cc @ramyaragupathy

@royallsilwallz @suzit-10
Fix extraIdParams field not populating in iD editor issue for custo…
e0b4f24 
…m imagery

- Related to #6676
@royallsilwallz @suzit-10
Resolve imagery offset issue in iD editor
c9b7e5d 
- Fix previous offset appearing issue in projects
- Fix custom imagery persisting from previous project issue
- Related to #6676
@suzit-10 suzit-10 force-pushed the fix/6676-additional-id-url-param-issue branch from d5794cf to c9b7e5d Compare November 20, 2025 08:01
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 20, 2025

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ramyaragupathy ramyaragupathy merged commit f36f5db into develop Nov 20, 2025
9 checks passed
@ramyaragupathy
Copy link
Copy Markdown
Member

ramyaragupathy commented Nov 20, 2025

Thanks @royallsilwallz for closing this 🙏 - looking forward to releasing this very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suzit-10 suzit-10 suzit-10 approved these changes

@manjitapandey manjitapandey manjitapandey approved these changes

Assignees

No one assigned

Labels

scope: frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Additional iD URL parameter for imagery offset is not working

4 participants

@royallsilwallz @manjitapandey @ramyaragupathy @suzit-10