Fix: Enhance TasksMap zoom behavior#7199
Open
sumitdahal7 wants to merge 1 commit intohotosm:developfrom
Open
Conversation
…ed tasks and optimize map re-zooming.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What type of PR is this? (check all applicable)
Related Issue
Fixes: #7052
Describe this PR
This PR enhances the
TasksMapcomponent by implementing a robust, programmatic zooming mechanism for specific tasks and adding UI interaction guards to improve the overall navigation experience.Changes:
Task-Specific Zooming: Implemented zoomedTaskId support that allows the map to automatically calculate and fit its bounds (using @turf/bbox) to a specific task or a group of tasks.
Redundant Zoom Prevention: Introduced a
lastZoomedIdRefutilizing JSON serialization to perform value-based comparisons on task selections. This ensures the map doesn't unnecessarily or re-zoom whenmapResultsor other dependencies update unless the task selection has actually changed.Consistent State Reset: Optimized the cleanup logic within
useLayoutEffectto correctly reset tracking references when task selections are cleared (null or empty array), ensuring reliable behavior on subsequent selections.Screenshots