Open
Conversation
Author
|
Changed logo and search bar |
nathanmsmith
requested changes
Jun 27, 2023
Member
nathanmsmith
left a comment
nathanmsmith
left a comment
There was a problem hiding this comment.
Sorry I missed this earlier!
Member
There was a problem hiding this comment.
Can we remove all these .DS_Store files? They're a mac specific thing that shouldn't be in git!
Member
There was a problem hiding this comment.
Just to confirm, we aren't actually using these svg files anywhere are we? It seems like we're just using the SVGs defined in .erb files.
| <div class="flex items-center"> | ||
| <%= render "icons/fire", classes: "h-14 w-14" %> | ||
| <h1 class="ml-1 text-3xl font-extrabold hidden lg:block">hotseat.io</h1> | ||
| <%= render "icons/hotseatlogotext_red", classes: "absolute w-522 h-150 left-101 top-340" %> |
Member
There was a problem hiding this comment.
Can we avoid using absolute positioning here? Happy to pair on this with you if helpful!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deployment
rake sorbet:update:allto generate their types.rake sorbet:update:allto generate their types.env RAILS_ENV=production rails db:migrate.bundle exec erd.make deploy.