Allow reconnection after terminate() via bind() - #10
Merged
Conversation
When terminate() is called, subsequent bind() calls with channels now establish a new connection, fulfilling the documented contract that "reconnecting with this instance will require re-binding to client events and re-subscribing to channel events".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
terminate()is called, the client closes its connection and clears all bindings. The JSDoc contract states that "reconnecting with this instance will require re-binding to client events." This PR fulfills that contract by allowingbind()calls with channels to establish a new connection after termination.Changes
#terminatedflag to track when the client has been explicitly terminatedbind()with a channel, if terminated, create a newConnectionto allow reconnectionbind()afterterminate()establishes a fresh connection with an open WebSocketAll 140 tests pass with 100% coverage maintained.