Fix test suite hanging after completion - #6
Merged
Conversation
Add a #closed flag to Connection that is set in close(). Check it in onopen before creating the 5-second connected-message timeout. This prevents orphaned timers when terminate() is called before the async WebSocket open event fires. Because initialize() is async, close() can run before the WebSocket is created, so the existing clearTimeout in close() is a no-op. The #closed flag on the Connection instance persists across that async boundary.
bensie
force-pushed
the
bensie/fix-test-suite-hang
branch
from
March 6, 2026 02:19
f74415e to
2308f22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard the connected-message timeout creation in
onopen()with an#autoReconnectcheck. This prevents orphaned timers from keeping the Node process alive when tests callterminate()before the WebSocket's asynconopencallback fires.Test plan