Add ESM build output for bundler resolution - #9
Merged
Conversation
This adds ESM format output (dist/hotsock.esm.js and dist/hotsock.esm.min.js) to rollup and declares the module entry point in package.json. Bundlers like Vite now correctly resolve the named export 'HotsockClient' instead of falling back to the UMD build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds ESM format output files and declares the module entry point in package.json to support bundlers like Vite, Webpack, and Rollup. This fixes the SyntaxError where bundlers couldn't find the named export 'HotsockClient' when using the package.
Changes
dist/hotsock.esm.jsanddist/hotsock.esm.min.jsoutputs to rollup config"module"field to package.json pointing to the ESM build