Base64-encode responses with non-identity Content-Encoding - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes silent corruption of compressed HTTP responses:
responseBody()decided base64-vs-plaintext purely from Content-Type, so a handler behind gzip middleware (e.g.Content-Encoding: gzipwithContent-Type: application/json) had its compressed bytes emitted as a literal JSON string. Found in a real production integration.responseBody()now always base64-encodes when the response declares any non-identity Content-Encoding (handling multi-coding values likegzip, brand multiple header lines), which covers all four adapters since they funnel through it; the streaming path sends raw bytes and is unaffected. Content-Type sniffing is also skipped whenever Content-Encoding is set, matching net/http server behavior. Includes an end-to-end regression test that round-trips a gzip response through the FunctionURL adapter, plus unit coverage for the newisEncodedContenthelper andresponseBodyencoding decisions.