Allow custom path config properties and settings
#114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the JSON parser would only accept strings as possible values for `properties`. Because of this it was impossible to create a custom data structure inside the path-configuration file. The iOS configuration parser does support non string values, matching parity with the other platform. In doing so it allows for custom extension functions to be added to `PathConfigurationProperties` which allows developers to serialize their own data structures.
* main: (60 commits) Support the path config `animated` option, bringing it in line with the available iOS option Extract the destination animation logic, since it's getting complex Fix demo app native screen toolbar Fix when navigating from a modal sheet dialog -> modal sheet dialog with an ADVANCE action. Only one dialog is now permitted on top of the stack, so if there's already an active dialog, it will be dismissed before navigating to the next dialog. Rename the new path config ClientConfig class to LoadOptions to match the iOS APi Update val name from dismissToDefaultContext -> dismissModalContext Adjust modal animations further, so navigating to a modal context or dismissing the modal context always animates, regardless of a "replace" action. Always show the modal navigation animation, even when navigating from modal -> modal Fix modal enter/exit animations Update code comment Change how a modal is dismissed with a visit proposal "replace" action. First, pop the modal (acting as a "replace" action), then "advance" to the new visit proposal url. Fix tiny context mix-up in CONTRIBUTING.md Allow CI tests to run on PRs from external contributors remove `HotwireTests` `ClientConfig` data class & refactor Allow passing an optional ClientConfig when calling Hotwire.loadPathConfiguration() to pass custom HTTP headers when loading the path configuration file. remove func from HotwireConfig remove old tests remove singleton `PathConfigurationClientConfig` internal & `HotwireConfig` sets ... # Conflicts: # core/src/main/assets/json/test-configuration.json # core/src/main/kotlin/dev/hotwire/core/turbo/config/PathConfiguration.kt # core/src/test/kotlin/dev/hotwire/core/turbo/config/PathConfigurationTest.kt
leonvogt
added a commit
to leonvogt/hotwire-native-dev-tools
that referenced
this pull request
Apr 27, 2025
…strings In this Hotwire Native Android PR: hotwired/hotwire-native-android#114, they changed the properties from `HashMap<String, String>` to `HashMap<String, Any>`. Since `HashMap<String, Any>` can't be serializable without additional effort, we simply try to convert the values to strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #79 with additional improvements.
Additionally, now
settingsaccepts custom data structures.