Fix crash when accessing currentDestination #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayohms
reviewed
Aug 20, 2025
| val currentDestination: HotwireDestination? | ||
| get() = currentDialogDestination as? HotwireDestination | ||
| ?: host.childFragmentManager.primaryNavigationFragment as? HotwireDestination | ||
| ?: if (host.isAdded) { |
Contributor
There was a problem hiding this comment.
How about using the NavigatorHost.isReady() function, which is a bit more comprehensive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes,
currentDestinationis accessed outside of the lifecycle of theNavigatorHostfragment.Navigator.logEventtries to callNavigator.getCurrentDestination.This in turn calls
NavigatorHost/Fragment.getChildFragmentManager.When the
Fragment(NavigatorHost) is not attached, it throws anIllegalStateException("Fragment ... has not been attached yet.").I believe it should be enough to check that the Fragment is added and if it isn't, return
null(which is a valid value forNavigator.getCurrentDestination).