Skip to content

Conversation

@mbarta
Copy link
Collaborator

@mbarta mbarta commented Jan 2, 2025

CookieManager.flush function documentation states:

This call will block the caller until it is done and may perform I/O.

This may result in ANRs for applications using the library.
This PR adds a fix by moving the call off the main thread.

@mbarta mbarta requested review from jayohms and jhutarek January 2, 2025 12:47
@mbarta mbarta self-assigned this Jan 2, 2025
Copy link
Contributor

@jayohms jayohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@mbarta mbarta merged commit 31c1db3 into main Jan 2, 2025
1 check passed
@mbarta mbarta deleted the mb/persist_cookies_in_bg branch January 2, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants