Fix race condition in View#render by removing shared mutable state

src/core/frames/frame_controller.js

@@ -281,11 +281,7 @@ export class FrameController {
       detail: { render }
     } = event
 
-    if (this.view.renderer && render) {
-      this.view.renderer.renderElement = render
-    }
-
-    return !defaultPrevented
+    return { immediateRender: !defaultPrevented, render }
   }
 
   viewRenderedSnapshot(_snapshot, _isPreview, _renderMethod) {}

src/core/session.js

@@ -340,11 +340,7 @@ export class Session {
       detail: { render }
     } = event
 
-    if (this.view.renderer && render) {
-      this.view.renderer.renderElement = render
-    }
-
-    return !defaultPrevented
+    return { immediateRender: !defaultPrevented, render }
   }
 
   viewRenderedSnapshot(_snapshot, _isPreview, renderMethod) {

src/core/view.js

@@ -65,20 +65,19 @@ export class View {
     if (shouldRender) {
       try {
         this.renderPromise = new Promise((resolve) => (this.#resolveRenderPromise = resolve))
-        this.renderer = renderer
         await this.prepareToRenderSnapshot(renderer)
 
         const renderInterception = new Promise((resolve) => (this.#resolveInterceptionPromise = resolve))
-        const options = { resume: this.#resolveInterceptionPromise, render: this.renderer.renderElement, renderMethod: this.renderer.renderMethod }
-        const immediateRender = this.delegate.allowsImmediateRender(snapshot, options)
+        const options = { resume: this.#resolveInterceptionPromise, render: renderer.renderElement, renderMethod: renderer.renderMethod }
+        const { immediateRender, render } = this.delegate.allowsImmediateRender(snapshot, options)
+        if (render) renderer.renderElement = render
         if (!immediateRender) await renderInterception
 
         await this.renderSnapshot(renderer)
-        this.delegate.viewRenderedSnapshot(snapshot, isPreview, this.renderer.renderMethod)
+        this.delegate.viewRenderedSnapshot(snapshot, isPreview, options.renderMethod)
         this.delegate.preloadOnLoadLinksForView(this.element)
         this.finishRenderingSnapshot(renderer)
       } finally {
-        delete this.renderer
         this.#resolveRenderPromise(undefined)
         delete this.renderPromise
       }