Add on_send_message method to Handler #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is analogue to `on_send_frame`. While `on_send_frame` is also called for messages prior to fragmentation, that's a low-level method called for any frame, no matter whether it's a user defined message or something else (like a frame from a close message).
|
I am considering this, I don't know if I'm sold on it yet. It would be great to have more opinions, but I can see how it might be useful. I just don't have the time right now for a full review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is analogue to
on_send_frame. Whileon_send_frameis also called for messages prior to fragmentation, that's a low-level method called for any frame, no matter whether it's a user defined message or something else (like a frame from a close message).