Add DisplayManager utility for improved display handling#1621
Merged
Add DisplayManager utility for improved display handling#1621
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new DisplayManager utility class to improve display handling in Stretchly by consolidating scattered display-related functions. The refactoring extracts complex display logic from the main.js file into a dedicated utility class that provides a cleaner API for window positioning and display management.
Key changes:
- Creates a new DisplayManager utility class with comprehensive test coverage
- Replaces multiple duplicated display functions in main.js with DisplayManager methods
- Changes Math.ceil to Math.floor for display calculations to improve positioning accuracy
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/utils/displayManager.js | New utility class providing centralized display management methods |
| test/displayManager.js | Comprehensive test suite covering all DisplayManager functionality |
| app/main.js | Refactored to use DisplayManager instead of inline display functions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.