Add advanced option to hide Strict Mode preferences#1643
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new advanced option to hide the Strict Mode preferences section from the preferences window, similar to other existing corporate installation features.
- Adds
hideStrictModePreferencessetting to hide strict mode UI elements - Implements UI logic to conditionally hide strict mode preferences
- Documents the new feature for administrators
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/utils/defaultSettings.js | Adds new hideStrictModePreferences setting with default value false |
| app/preferences.html | Adds data-strict-mode attributes to strict mode UI elements for targeting |
| app/preferences-renderer.js | Implements logic to hide strict mode elements and adjust spacing |
| README.md | Documents the new advanced option for corporate installations |
| CHANGELOG.md | Records the new feature in the changelog |
| .github/copilot-instructions.md | Adds linting instruction (unrelated to main feature) |
| document.querySelectorAll('[data-strict-mode]').forEach(element => { | ||
| element.classList.add('hidden') | ||
| }) | ||
| document.querySelector('#enablePostponeLong').closest('div').style.marginBottom = '56px' |
There was a problem hiding this comment.
The magic number '56px' should be replaced with a CSS class or a named constant to improve maintainability and make the spacing intention clearer.
Suggested change
| document.querySelector('#enablePostponeLong').closest('div').style.marginBottom = '56px' | |
| document.querySelector('#enablePostponeLong').closest('div').classList.add('mb-56px') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.