Adds new icon styles preference for tray #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new tray icon style preference that allows users to choose between default icon, time to break, or progress to break display styles in the menubar/tray icon.
Key Changes:
- Implemented new tray icon style preference with three options (default, time to break, progress to break)
- Added progress percentage calculation based on break intervals
- Removed the previous
timeToBreakInTraycontributor preference and replaced it with the new configurable preference
Reviewed changes
Copilot reviewed 6 out of 2070 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/breaksPlanner.js | Added null check for scheduler and new progress percentage calculation methods |
| app/contributor-preferences.html | Removed old time-to-break checkbox preference |
| app/css/contributor.css | Updated grid layout after removing preference option |
| app/css/preferences.css | Adjusted grid row positioning for theme settings |
| README.md | Updated documentation to reflect new trayIconStyle preference and removed old timeToBreakInTray documentation |
| CHANGELOG.md | Documented the new feature addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1558