Add UI for editing custom break messages#1760
Open
steveszat wants to merge 2 commits into
Open
Conversation
Owner
|
Please follow instructions in https://github.com/hovancik/stretchly/blob/trunk/CONTRIBUTING.md, I want to talk about the functionality and UX before doing code changes. |
Author
|
Thanks for the reply. Sorry, I’m new to contributing to open source, and this is my first attempt, so I missed that I should have opened an issue and discussed the functionality/UX before putting together a PR. I’ll go ahead and create an issue as the contributing guide suggests, and I’d be happy to discuss the functionality and UX there first if you’re open to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes existing custom break message settings in the Preferences UI.
Users can now:
This PR also reloads break ideas immediately when these settings change, so users do not need to restart Stretchly for updates to take effect.
Why
Stretchly already supports storing custom
microbreakIdeasandbreakIdeasin settings, but that capability is currently hidden behind manual config editing.This change makes that built-in configurability accessible from the UI without changing the underlying feature model.
This is especially useful because break-message preferences are highly subjective. This PR lets users decide what messages are useful for them.
Implementation details
Added a new Custom Messages section to Preferences
Added inline editing for message text
Added an Enabled checkbox per message
Added Delete controls
Added Add new message support
Added a Use custom messages checkbox bound to
useIdeasFromSettingsReloaded break ideas at runtime when:
microbreakIdeaschangesbreakIdeaschangesuseIdeasFromSettingschangesNotes
Type of change
Checklist