Devcontainer improvement #1766
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| FROM mcr.microsoft.com/devcontainers/javascript-node:1-22-bookworm | ||
|
|
||
| RUN apt-get update \ | ||
| && export DEBIAN_FRONTEND=noninteractive \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| libasound2 \ | ||
| libatk-bridge2.0-0 \ | ||
| libgbm1 \ | ||
| libgtk-3-0 \ | ||
| libinput-dev \ | ||
| libnss3 \ | ||
| libudev-dev \ | ||
| libxshmfence1 \ | ||
| xvfb \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| { | ||
| "name": "Stretchly Dev", | ||
| "build": { | ||
| "dockerfile": "Dockerfile", | ||
| "context": ".." | ||
| }, | ||
| "workspaceFolder": "/workspaces/stretchly", | ||
| "remoteUser": "node", | ||
| "updateRemoteUserUID": true, | ||
| "runArgs": [ | ||
| "--init", | ||
| "--network=host" | ||
| ], | ||
| "mounts": [ | ||
| "source=stretchly-node-modules,target=/workspaces/stretchly/node_modules,type=volume", | ||
| "source=${localEnv:HOME}/.ssh,target=/home/node/.ssh,type=bind,readonly", | ||
| "source=${localEnv:HOME}/.gitconfig,target=/home/node/.gitconfig,type=bind,readonly", | ||
| "source=${localEnv:HOME}/.npmrc,target=/home/node/.npmrc,type=bind,readonly" | ||
| ], | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/git:1": {} | ||
| }, | ||
| "initializeCommand": "touch ~/.gitconfig ~/.npmrc", | ||
| "postCreateCommand": "sudo mkdir -p /workspaces/stretchly/node_modules && sudo chown -R node:node /workspaces/stretchly/node_modules && npm install && find node_modules/.bin -maxdepth 1 -type l -exec sh -c 'chmod u+x \"$(readlink -f \"$0\")\"' {} \\;", | ||
|
|
||
| "forwardPorts": [ | ||
| 9222 | ||
| ], | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "dbaeumer.vscode-eslint", | ||
| "vitest.explorer" | ||
| ], | ||
| "settings": { | ||
| "eslint.validate": [ | ||
| "javascript" | ||
| ], | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.eslint": "explicit" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ | |
| "scripts": { | ||
| "start": "electron .", | ||
| "dev": "cross-env NODE_ENV=development electron . --trace-warnings --trace-deprecation --enable-logging --remote-debugging-port=9222", | ||
| "dev:container": "cross-env NODE_ENV=development electron . --no-sandbox --trace-warnings --trace-deprecation --enable-logging --remote-debugging-port=9223 --remote-allow-origins=*", | ||
|
Owner
There was a problem hiding this comment. --remote-allow-origins=* is broad; --remote-allow-origins=http://localhost:9223 would be safer?
Owner
There was a problem hiding this comment. also, is there reason to use 9223? |
||
| "postinstall": "electron-builder install-app-deps", | ||
| "pack": "electron-builder build --dir", | ||
| "dist": "electron-builder build", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we make it use .nvmrc version? so I don't have to remember update this. Each Electron version is with specific node version so best to keep it in sync.