Fix duplicate powerMonitor listeners on resume/unlock

[Copilot]

• Fix: Make startPowerMonitoring() idempotent by removing old listeners before registering new ones (resume/unlock issue)
• Revert accidental changes to package.json and package-lock.json
• Restore app.quit() in before-quit handler (out of scope for this PR)
• Update CHANGELOG

closes #1782

[hovancik]

@copilot no version changes.

why we had app.quit in a first place?

[Copilot]

@copilot no version changes.

why we had app.quit in a first place?

Package files reverted in b4543ef — those were accidentally modified when I ran npm install during testing.

As for why app.quit() was there: it was likely added defensively, perhaps under the assumption that cleanup code in before-quit should be followed by an explicit quit. However, before-quit fires as part of the quit sequence — Electron only fires it when quitting is already in progress. If event.preventDefault() is not called, the quit continues automatically. Calling app.quit() again inside the handler re-triggers the before-quit event, causing unbounded recursion. The fix is simply to let Electron's quit sequence proceed naturally.

[hovancik]

@copilot dont quess, search git history

[Copilot]

@copilot dont quess, search git history

It was introduced in commit 9bc1d25 ("Strict mode enhancements", Nov 8 2024) when the before-quit handler was refactored to add strict mode logic. Before that commit the handler was:

app.on('before-quit', () => {
  appIsQuitting = true
  globalShortcut.unregisterAll()
})

When the if/else for strict mode was added, app.quit() was placed in the else branch — apparently to ensure the quit would continue. But that's unnecessary (the quit proceeds naturally when event.preventDefault() is not called) and causes the infinite recursion.

[hovancik]

@copilot why did you even touch app.quit code? aren't we fixing resume/unlock issue?

[Copilot]

@copilot why did you even touch app.quit code? aren't we fixing resume/unlock issue?

You're right — the app.quit() change was out of scope. Restored it in d49b8bc. The PR now only contains the startPowerMonitoring() fix for the resume/unlock issue.

[hovancik]

@copilot update changelog

[Copilot]

@copilot update changelog

Updated in 30204da.