Sends deviceReady event when using Cached token#199
Open
fmonsalvo wants to merge 7 commits into
Open
Conversation
Collaborator
|
Hi @fmonsalvo thanks for your PR. It seems like there is a merge conflict, could you resolve this? |
Collaborator
|
I think that there is already an open PR to fix this. |
Contributor
Author
|
Hey guys, sorry for my late reply. If there is already an open PR for this I should close it. Else I'll fix the merge issue and update it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some applications may rely on the deviceReady event to be thrown to understand the VOIP functionality is ready. When using the cached token the lib was not sending the deviceReady event.
This PR fixes that.