Skip to content
This repository was archived by the owner on Oct 2, 2024. It is now read-only.

draft: optional binds #1605

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bin/ch_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ struct bind BINDS_DEFAULT[] = {
{ 0 }
};

#ifdef ADD_BINDS
/* add more optional binds based on autoconf. */
#endif

/* Architectures that we support for seccomp. Order matches the
corresponding table below.

Expand Down
32 changes: 29 additions & 3 deletions doc/install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ be built.
Dependency selection: :code:`--with-FOO`
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Some dependencies can be specified as follows. Note only some of these support
:code:`--with-FOO=no`, as listed.

:code:`--with-libsquashfuse={yes,no,PATH}`
Whether to link with :code:`libsquashfuse`. Options:

Expand Down Expand Up @@ -124,6 +121,35 @@ Some dependencies can be specified as follows. Note only some of these support
Path to Python used by :code:`sphinx-build`. Default: shebang of
:code:`sphinx-build`.

Some dependencies can be specified as follows. Note only some of these support
:code:`--with-FOO=no`, as listed.
Comment on lines +124 to +125
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this move?


Optional bind selection: :code:`--bind-FOO`
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment on lines +127 to +128
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these will want to be spelled --enable-bind-FOO, because --enable gets special treatment in Autotools.


By default, :code:`ch-run` binds the minimal number mount points needed to run.
You can add more files with:

:code:`--bind-path={PATH[:PREFIX}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:code:`--bind-path={PATH[:PREFIX}`
:code:`--bind-path={HOST_PATH[:IMAGE_PATH]}`

Add file from path to to ch-run optional default run-time binds.

* Path to host file. Optionally bind at prefix if set; otherwise,
:code:`/usr/local/lib`
Comment on lines +133 to +137
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this (i.e., arbitrary default bind-mounts) can be implemented, but I'm not sure offhand how to do it. If there's not an immediate use case, maybe leave this for future work?


:code:`--bind-libfabric={PATH[:PREFIX]}`
Add host libfabric to ch-run optional default run-time binds.

* Path to host :code:`libfabric.so`. Optionally bind at prefix if set;
otherwise :code:`/usr/local/lib`.

:code:`--bind-fi-provider={PATH[:PREFIX]}`
Add host libfabric shared fabric provider to ch-run optional default run-time
binds.

* Path to host libfabric shared provider, with :code:`*-fi.so` suffix.
Optionally bind at prefix if set;
otherwise :code:`/usr/local/lib/libfabric`.

Less strict build: :code:`--enable-buggy-build`
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Expand Down
1 change: 1 addition & 0 deletions examples/Dockerfile.libfabric
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ RUN dnf install -y --setopt=install_weak_deps=false \
libibumad-devel \
librdmacm \
librdmacm-devel \
libssh \
rdma-core \
make \
numactl-devel \
Expand Down