This repository was archived by the owner on Oct 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 60
draft: optional binds #1605
Draft
j-ogas
wants to merge
1
commit into
master
Choose a base branch
from
ch-run_fromhost
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
draft: optional binds #1605
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -88,9 +88,6 @@ be built. | |||||
Dependency selection: :code:`--with-FOO` | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
|
||||||
Some dependencies can be specified as follows. Note only some of these support | ||||||
:code:`--with-FOO=no`, as listed. | ||||||
|
||||||
:code:`--with-libsquashfuse={yes,no,PATH}` | ||||||
Whether to link with :code:`libsquashfuse`. Options: | ||||||
|
||||||
|
@@ -124,6 +121,35 @@ Some dependencies can be specified as follows. Note only some of these support | |||||
Path to Python used by :code:`sphinx-build`. Default: shebang of | ||||||
:code:`sphinx-build`. | ||||||
|
||||||
Some dependencies can be specified as follows. Note only some of these support | ||||||
:code:`--with-FOO=no`, as listed. | ||||||
|
||||||
Optional bind selection: :code:`--bind-FOO` | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
Comment on lines
+127
to
+128
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think these will want to be spelled |
||||||
|
||||||
By default, :code:`ch-run` binds the minimal number mount points needed to run. | ||||||
You can add more files with: | ||||||
|
||||||
:code:`--bind-path={PATH[:PREFIX}` | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
Add file from path to to ch-run optional default run-time binds. | ||||||
|
||||||
* Path to host file. Optionally bind at prefix if set; otherwise, | ||||||
:code:`/usr/local/lib` | ||||||
Comment on lines
+133
to
+137
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm pretty sure this (i.e., arbitrary default bind-mounts) can be implemented, but I'm not sure offhand how to do it. If there's not an immediate use case, maybe leave this for future work? |
||||||
|
||||||
:code:`--bind-libfabric={PATH[:PREFIX]}` | ||||||
Add host libfabric to ch-run optional default run-time binds. | ||||||
|
||||||
* Path to host :code:`libfabric.so`. Optionally bind at prefix if set; | ||||||
otherwise :code:`/usr/local/lib`. | ||||||
|
||||||
:code:`--bind-fi-provider={PATH[:PREFIX]}` | ||||||
Add host libfabric shared fabric provider to ch-run optional default run-time | ||||||
binds. | ||||||
|
||||||
* Path to host libfabric shared provider, with :code:`*-fi.so` suffix. | ||||||
Optionally bind at prefix if set; | ||||||
otherwise :code:`/usr/local/lib/libfabric`. | ||||||
|
||||||
Less strict build: :code:`--enable-buggy-build` | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
|
||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this move?