Correctly reshape decompressed array data from [] notation. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a unit test for returned shape. Closes #5.
mhasself
reviewed
Mar 5, 2025
src/flacarray/array.py
Outdated
| full_shape = tuple(leading) + (self._shape[-1],) | ||
| else: | ||
| full_shape = tuple(leading) + (last - first,) | ||
| return np.squeeze(arr.reshape(full_shape)) |
There was a problem hiding this comment.
I don't understand this fully but the use of squeeze is suspicious... what if the thing I'm asking for has a legitimate dimension of length 1? E.g. something[0,:1,:]?
To convince me ... add a test case that includes slice(0, 1).
There was a problem hiding this comment.
This was a really good point, and indeed the output dimensions did not match expectations. I have now overhauled __getitem__() and expanded the unit tests to compare the dimensions of the sliced output to the corresponding dimensions from slicing the input numpy array. Thanks for re-reviewing at your convenience.
…t compress the output shape. Change unit tests to compare cases against numpy array slicing results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a unit test for returned shape. Closes #5.