WIP

Signed-off-by: Dave Streeter <[email protected]>

Author: streeterd

system/jlib/jlog.cpp

@@ -2381,7 +2381,7 @@ static Singleton<bool> firstUpdateConfigHookCall;
 static bool firstUpdateConfigHookCallValue{true};
 bool queryFirstUpdateConfigHookCall()
 {
-    return *firstUpdateConfigHookCall.query([] () { return &firstUpdateConfigHookCallValue; });;
+    return *firstUpdateConfigHookCall.query([] () { return &firstUpdateConfigHookCallValue; });
 }
 
 auto updateConfigFunc = [](const IPropertyTree *oldComponentConfiguration, const IPropertyTree *oldGlobalConfiguration)
@@ -2390,15 +2390,17 @@ auto updateConfigFunc = [](const IPropertyTree *oldComponentConfiguration, const
 };
 static CConfigUpdateHook configUpdateHook;
 // NOTE:    The parameter updateConfigOnTheFly value of true signifies that the thread
-//          safe caller has completed setting up the logging configuration and that
-//          any further configuration changes are from non-thread safe callers.
-void setupContainerizedLogMsgHandler(bool updateConfigOnTheFly)
-{
-    // NOTE:    We need to allow the first config update hook call to update the config
-    //          as if it was not called from the config update hook.
-    //          This is to allow the configuration to be setup by the thread safe caller.
-    //          In practice this means allowing 2 calls to setupContainerizedLogMsgHandler
-    //          before the update config hook is allowed to prevent on the fly format changes.
+//          safe caller has completed setting up the logging configuration (normally
+//          from a main call).
+//          Any further configuration changes are from non-thread safe callers.
+//          EXCEPT: There are 2 calls to setupContainerizedLogMsgHandler that are
+//          thread-safe. In order to allow them to change the log format (if required)
+//          etc we need to allow the first config update hook call to update the config
+//          as if it was not called from the config update hook.
+    void setupContainerizedLogMsgHandler(bool updateConfigOnTheFly)
+{
+    // Alow the first config update hook call to update the config as if it was not
+    // called from the config update hook to allow log configuration changes.
     if(updateConfigOnTheFly && queryFirstUpdateConfigHookCall())
     {
         firstUpdateConfigHookCallValue = false;