Skip to content

HPCC-33491 Improve rowservice tracing #19796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2025
Merged

HPCC-33491 Improve rowservice tracing #19796

merged 3 commits into from
May 21, 2025

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Apr 29, 2025

  • Added file process time tracking
  • Improved error reporting

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jpmcmu
HPCC-33491 Improve rowservice tracing
6495574 
- Added file process time tracking
- Improved error reporting

Signed-off-by: James McMullan [email protected]
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33491

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@jpmcmu jpmcmu requested a review from jakesmith April 29, 2025 13:09
jakesmith
jakesmith reviewed Apr 29, 2025
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu - looks fine overall, but 1 issue/question.

fs/dafsserver/dafsserver.cpp Outdated
@@ -4919,6 +4932,10 @@ class CRemoteFileServer : implements IRemoteFileServer, public CInterface
Owned<IRemoteActivity> outputActivity;
OpenFileInfo fileInfo;

ISpan* requestSpan = queryNullSpan();
if (fileInfo.remoteRequest)
requestSpan = fileInfo.remoteRequest->queryRequestSpan();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fileInfo.remoteRequest is always going to be null here..
Should this be moved ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith It should only be null on the first request of newstream, with the subsequent continue requests it should have a value, but it isn't super useful outside of the continue context, so I will move it.

@jpmcmu jpmcmu requested a review from jakesmith May 8, 2025 19:28
jakesmith
jakesmith reviewed May 12, 2025
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu - 1 minor comment/question, but looks good.

fs/dafsserver/dafsserver.cpp Outdated
if (activity->queryIsReadActivity())
processRead(requestTree, responseMb);
else if (activity->queryIsWriteActivity())
processWrite(requestTree, restMb, responseMb);

if (activeSpan->isValid())
processingTimeNS += (nsTick() - processStartTime);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there's an exception in process* then this won't happen.
Can you use a RAII pattern, so the time guaranteed to be accounted for?

@jpmcmu jpmcmu requested a review from jakesmith May 20, 2025 13:08
jakesmith
jakesmith approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu - looks good afaics. Please squash.

@ghalliday ghalliday merged commit e7f867c into hpcc-systems:candidate-9.12.x May 21, 2025
56 checks passed
@ghalliday
Copy link
Member

Oops - merged before it had been squashed.

@github-actions GitHub Actions
Copy link

Jirabot Action Result:
Added fix version: 9.12.6
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmith jakesmith jakesmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpmcmu @ghalliday @jakesmith