-
Notifications
You must be signed in to change notification settings - Fork 149
fix all blogs query #2969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix all blogs query #2969
Conversation
✅ Deploy Preview for hpe-dev-portal ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
#2958 issue has been addressed by this PR @choukden @Didier-Lalli please validate and approve this PR Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Chetan,
Thank you for raising this PR.
In the preview of this PR, I still see Featured blog posts in "Others" category.
For example, the blog post from Didier (featured blog post) is seen in "Others":
Getting started with webhooks on HPE GreenLake cloud
Same for the blog post from Antonio Fin (a featured blog) seen in "Others":
LLM Agentic Tool Mesh: Orchestrating agentic tools for the AI revolution
Thanks,
Denis
Hi @choukden ,
Do we need to exclude more tags? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chethan-b-hpe ; @Didier-Lalli
Hi Chethan
Discussing with Didier, we believe it may make sense to remove the category "Others" from the Blog page. So we would have all the blog posts visible in the "All" categories. And for the blog posts that are tied to a specific landing page through appropriate tags, they will also appear in the appropriate category: HPE GreenLake, Products, or Open-Source.
It might be worth trying to implement this change in the PR #2969 and see the result in the Preview of the PR.
Opinion? Concerns?
Thanks,
Denis
I had removed others tab , let me know if its fine in preview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chethan-b-hpe , @Didier-Lalli
Hi Chethan, Didier,
The preview looks good to me without the "Others" category.
However, I notice that the five (5) blog posts that are listed in the "Featured Blogs" (https://developer.hpe.com/blog/) are not listed in "ALL" category.
Would it be possible to get the Featured blogs listed "ALL" category?
Thanks,
Denis
@choukden , OOPS sorry forgot to commit one of the file....😄 , commited, please check now Thanks for the notice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chethan-b-hpe
Looks good to me!
@Didier-Lalli
Could you please double check this is okay for you, and approve.
Thanks
Denis
@Didier-Lalli If all good with preview, shall I merge this PR? |
removed check for feature blog in all blogs query