Skip to content

fix all blogs query #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix all blogs query #2969

wants to merge 4 commits into from

Conversation

chethan-b-hpe
Copy link
Collaborator

removed check for feature blog in all blogs query

Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for hpe-dev-portal ready!

Name Link
🔨 Latest commit e1c0404
🔍 Latest deploy log https://app.netlify.com/sites/hpe-dev-portal/deploys/67dc07c2a2817700081b2088
😎 Deploy Preview https://deploy-preview-2969--hpe-dev-portal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2969.d2wz01xj8bm9sl.amplifyapp.com

@chethan-b-hpe
Copy link
Collaborator Author

#2958 issue has been addressed by this PR

@choukden @Didier-Lalli please validate and approve this PR

Thanks!

Copy link
Collaborator

@choukden choukden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chethan-b-hpe

Hi Chetan,

Thank you for raising this PR.

In the preview of this PR, I still see Featured blog posts in "Others" category.

For example, the blog post from Didier (featured blog post) is seen in "Others":
Getting started with webhooks on HPE GreenLake cloud

Same for the blog post from Antonio Fin (a featured blog) seen in "Others":
LLM Agentic Tool Mesh: Orchestrating agentic tools for the AI revolution

Thanks,
Denis

@chethan-b-hpe
Copy link
Collaborator Author

Hi @choukden ,
sure let me disable the featuredBlog there and I need to take a look we are excluding few tags in other posts , these are the tags excluding in others:

"opensource" "hpe-ezmeral-container-platform" "hpe-ezmeral" "spiffe-and-spire-projects" "hpe-ezmeral-data-fabric" "hpe-greenlake" "chapel" "grommet" "hpe-alletra" "deep-learning-cookbook" "hpe-3par-and-primera" "hpe-nimble-storage" "hpe-oneview" "hpe-oneview-global-dashboard" "ilo" "data-services-cloud-console" "determined-ai" "cray"

Do we need to exclude more tags?

Copy link
Collaborator

@choukden choukden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chethan-b-hpe ; @Didier-Lalli

Hi Chethan

Discussing with Didier, we believe it may make sense to remove the category "Others" from the Blog page. So we would have all the blog posts visible in the "All" categories. And for the blog posts that are tied to a specific landing page through appropriate tags, they will also appear in the appropriate category: HPE GreenLake, Products, or Open-Source.

It might be worth trying to implement this change in the PR #2969 and see the result in the Preview of the PR.

Opinion? Concerns?

Thanks,
Denis

@chethan-b-hpe
Copy link
Collaborator Author

@choukden @Didier-Lalli ,

I had removed others tab , let me know if its fine in preview.

Copy link
Collaborator

@choukden choukden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chethan-b-hpe , @Didier-Lalli

Hi Chethan, Didier,

The preview looks good to me without the "Others" category.
However, I notice that the five (5) blog posts that are listed in the "Featured Blogs" (https://developer.hpe.com/blog/) are not listed in "ALL" category.

Would it be possible to get the Featured blogs listed "ALL" category?

Thanks,

Denis

@chethan-b-hpe
Copy link
Collaborator Author

chethan-b-hpe commented Mar 20, 2025

@choukden , OOPS sorry forgot to commit one of the file....😄 , commited, please check now

Thanks for the notice.

@choukden choukden requested a review from Didier-Lalli March 21, 2025 14:59
Copy link
Collaborator

@choukden choukden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chethan-b-hpe
Looks good to me!

@Didier-Lalli
Could you please double check this is okay for you, and approve.

Thanks
Denis

@chethan-b-hpe
Copy link
Collaborator Author

@Didier-Lalli If all good with preview, shall I merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants