CON-4271 Updated getNetworkInterface for IPV6 support and the iSCSI discovery flow of HandleIscsiDiscovery and addIscsiPortBinding workflow #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yatish-Sriram
requested review from
datamattsson,
dileepds,
rohit-balakrishna and
sijeesh
as code owners
…iscovery flow of HandleIscsiDiscovery and addIscsiPortBinding workflow Signed-off-by: yatish-sriram-pothuri <[email protected]>
Yatish-Sriram
force-pushed
the
CON-4271
branch
from
9481f47 to
d9ab245
Compare
Collaborator
rohit-balakrishna
left a comment
rohit-balakrishna
left a comment
There was a problem hiding this comment.
@Yatish-Sriram , please also push the test code that you wrote along with a small readme.md on how to use it. It would be helpful.
|
|
||
| // formatIPWithPort formats an IP address with port, using brackets for IPv6 | ||
| func formatIPWithPort(ip string, port int) string { | ||
| if strings.Contains(ip, ":") { |
Collaborator
There was a problem hiding this comment.
We can use the net.ParseIP(ip) function to validate the IP and use To4 or To6 function to check if it is IPv4 or V6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CON-4271 Updated getNetworkInterface for IPV6 support and the iSCSI discovery flow of HandleIscsiDiscovery and addIscsiPortBinding workflow