Skip to content

Conversation

@MasterDash5
Copy link
Contributor

Mojang forgot to check if a component contains an insertion when serializing to JSON. This means if a component's style only contains an insertion, the serializer won't add the insertion to the JSON.

Insertion is missing:
/tellraw @a {"text":"test","insertion":"test"}

Insertion is present:
/tellraw @a {"text":"test","insertion":"test","color":"white"}

This PR addds a check for insertion in ChatModifier.g(), which is used to check if a component contains any styling.
PandaAdventure also uses this serializer for NMS <-> Adventure, so the current Adventure implementation is also affected by this.

@uRyanxD uRyanxD merged commit 35e059d into hpfxd:master Nov 10, 2025
1 check passed
@MasterDash5 MasterDash5 deleted the chatmodifier-insertion branch November 17, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants