Check for insertion in ChatModifier #368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mojang forgot to check if a component contains an insertion when serializing to JSON. This means if a component's style only contains an insertion, the serializer won't add the insertion to the JSON.
Insertion is missing:
/tellraw @a {"text":"test","insertion":"test"}Insertion is present:
/tellraw @a {"text":"test","insertion":"test","color":"white"}This PR addds a check for insertion in
ChatModifier.g(), which is used to check if a component contains any styling.PandaAdventure also uses this serializer for NMS <-> Adventure, so the current Adventure implementation is also affected by this.