-
Notifications
You must be signed in to change notification settings - Fork 2
SwaLintBrowser & RC #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assumed set of objects in > Squeak 5.1
This reverts commit 984ef90. This is necessary as the master is at the present point still designated for development for 5.3.
(cause for some reason there is no other way for that workflow)
Bring changes to the main branch to develop
…llInstancesDo: Also only trigger the update once for adding all plugins. Tbh I did not test whether the update mechanism actually works because in practice every dialog has its own environment.
Previously, UI updates from progress reports made up 90% of the test running time. Reduce the granularity of updates and sort tests for fewer updates to avoid that. Fix progress bar size (always ending in 100%) by tracking duplicate test processing reports. Also cache source files globally.
* update copied code from Preference classes; update docs on how to update again (class comments) * use modern contract for pragma preferences (SystemChangeNotifer & accessed from defining classes) * simplify preference browser: remove singleton limitation
* use #containingWindow instead of preserving toolbuilder outputs * fix multiselection by adding observer updates required in newer Squeak versions * use accessors for more variables * UIManager default -> Project uiManager * dump descriptionCollection
...we should have a test for this...
…nspectSelectedResults with exploreSelectedResults
NB: Our change to noClassComments: was a breaking change, but one that harmonizes this test with the other ones.
They are confusing legacy and get lost after a #cleanUp:. Also remove other unused preference setters.
If global, then really global.
Closed
This has been fixed since Squeak 5.2.
…pected failure in squeak50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.