ChafaPalette: Inline palette search helpers - #335
Merged
Conversation
hpjansson
requested changes
Jun 9, 2026
hpjansson
left a comment
hpjansson
left a comment
Owner
There was a problem hiding this comment.
Looks good, but by convention the commit message should read ChafaPalette: ....
leonardcser
changed the title
leonardcser
force-pushed
the
pr-palette-inline
branch
from
June 9, 2026 18:28
2d5016c to
e381aa7
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_candidates and update_candidates_with_color_index_diff are called once per palette entry inside tight loops in pick_color_fixed_* functions. GCC does not inline them automatically at -O2, adding call/return overhead in a very hot path.
Mark both functions static inline. This is a pure compiler hint with no functional change.
Performance
Linux x86_64, AMD Ryzen 9 7900X, GCC 15.2 -O2,
perf stat -r 3