Change country_codes to countrycodes #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change address_details to addressdetails As documented at https://nominatim.org/release-docs/develop/api/Search/#parameters Compare: https://nominatim.openstreetmap.org/search.php?q=halifax&limit=3&country_codes=gb,ca https://nominatim.openstreetmap.org/search.php?q=halifax&limit=3&countrycodes=gb,ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change
address_detailstoaddressdetailsbut I haven't tested that.As documented at https://nominatim.org/release-docs/develop/api/Search/#parameters
Compare:
(result includes Halifax, Nova Scotia, which ought to be excluded: therefore this query is equivalent to simply: https://nominatim.openstreetmap.org/search.php?q=halifax&limit=3)
(successfully excludes Halifax, Nova Scotia, as intended).
Haven't made changes to the params to
osm_searchbecause obviously this would break compatibility with existing usage.I also added into the script an example of how to use
country_codes, because I took a long time to work out the proper syntax for that myself! Thought it might be helpful to others.