Skip to content

Added 2 slides on timing at the end of MoreSTL section #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

Added 2 slides on timing at the end of MoreSTL section #524

merged 1 commit into from
Aug 23, 2024

Conversation

sponce
Copy link
Contributor

@sponce sponce commented Aug 22, 2024

Note that I believe we should make a Chapter from the "MoreSTL" section. It starts to be too long and with many unrelated points

@sponce sponce requested a review from hageboeck August 22, 2024 08:11
hageboeck
hageboeck approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally approved, but do you think it's worth replacing the duration cast by duration / 1ms or duration / std::chrono::milliseconds(1) etc?

@sponce sponce merged commit 29df934 into master Aug 23, 2024
7 checks passed
@hageboeck hageboeck mentioned this pull request Sep 19, 2024
Closed
@sponce sponce mentioned this pull request Sep 30, 2024
Merged
@sponce sponce deleted the sponce_timing branch September 30, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hageboeck hageboeck hageboeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sponce @hageboeck