Add HTTP server timeouts to harden webhook#20
Merged
Conversation
Set ReadHeaderTimeout, ReadTimeout, WriteTimeout, and IdleTimeout on the webhook http.Server. Without them the server is vulnerable to Slowloris-style attacks where clients hold connections open by trickling bytes, exhausting goroutines. Also resolves gosec G112 (missing ReadHeaderTimeout). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit timeouts to the webhook
http.Server:ReadHeaderTimeout: 5sReadTimeout: 10sWriteTimeout: 10sIdleTimeout: 60sWhy
The server previously had no timeouts. This left it open to Slowloris-style attacks, where clients keep connections open by trickling bytes (e.g. never finishing the request headers), tying up goroutines until the server can no longer accept legitimate traffic. Splitting
ReadHeaderTimeoutfromReadTimeoutlets us be strict about header reads (always small) while leaving more headroom for the request body.Also resolves gosec G112 (missing
ReadHeaderTimeout).Testing
go build ./...go test ./...— all pass🤖 Generated with Claude Code