Reject non-POST requests to the webhook handler#22
Merged
Conversation
The apiserver always sends admission requests as POST. Reject any other method with 405 Method Not Allowed instead of attempting to unmarshal the body, avoiding wasted work and confusing error responses for stray requests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The webhook handler now rejects any non-
POSTrequest with405 Method Not Allowedbefore attempting to read or unmarshal the body.Why
The apiserver always sends admission requests as
POST. Previously any method (GET, PUT, etc.) would fall through to body reading and JSON unmarshalling, producing misleading400errors and doing needless work for stray or probing requests.Testing
go build ./...go test ./...— all pass, including a newTestHandleAdmissionReview_MethodNotAllowedcovering GET/PUT/DELETE🤖 Generated with Claude Code