Run race detector in test target, not build#23
Merged
Conversation
The -race flag enables Go's data race detector, which only does anything meaningful while running tests. Building with -race produced a slower, larger binary for no benefit. Move -race to the test target where it can actually catch races, and build a clean binary. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
-raceflag from thebuildtarget to thetesttarget:test:go test -race ./...build:go build -o grafana-operator-webhook -v .Why
Go's
-raceflag enables the data race detector, which only does anything meaningful while running code under test. Building the production binary with-racejust produced a slower, larger artifact with no benefit, while tests — where races actually surface — ran without it. This swaps them so races can actually be caught in CI.Testing
make test— passes with the race detector enabledmake build— produces a clean binary🤖 Generated with Claude Code