Agent/agent tdd/97b6c937#753
Open
frankwjy wants to merge 2 commits into
Open
Conversation
- google_news.py: Add MAX_PAGES=10 limit to pagination loop - google_news.py: Add reraise=True to make_request retry decorator - conditional_logic.py: Add MAX_MESSAGES=50 safety check in all analyst loops - tests: Add test_dead_loop_fix.py with 9 tests covering all fixes Addresses P1 dead loop risks identified in PROJ-20260612-001.
- MAX_PAGES: 10 → 50 - MAX_MESSAGES: 50 → 100 - max_tool_calls: 3 → 300 (all 4 analyst methods) - Updated tests to match new values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request 模板
📋 PR 类型
请标记此 PR 的类型：
📖 PR 描述
变更摘要
变更详情
相关 Issue
🤖 LLM 适配器集成检查清单
✅ 代码实现检查
适配器类实现
OpenAICompatibleBase的适配器类provider_name、api_key_env_var、base_url注册和集成
OPENAI_COMPATIBLE_PROVIDERS字典中注册了提供商__init__.py中添加了适配器导出sidebar.py中添加了提供商选项环境变量配置
.env.example中添加了 API Key 示例{PROVIDER}_API_KEY格式base_url配置✅ 测试和验证
基础功能测试
工具调用测试
集成测试
性能和稳定性测试
✅ 文档和配置
代码文档
用户文档
📝 测试报告
如果这是 LLM 适配器 PR，请提供以下信息：
提供商信息:
测试结果:
性能指标:
已知问题:
🧪 测试说明
如何测试此 PR
测试环境
破坏性变更
如果包含破坏性变更，请说明：
📊 影响范围
请标记此 PR 影响的组件：
🔗 相关链接
📷 截图/演示
✅ 检查清单
请确认以下项目：
代码质量
测试覆盖
文档更新
安全考虑
性能考虑
🏷️ 标签建议
请为此 PR 建议适当的标签：
enhancement- 新功能或改进bug- Bug 修复documentation- 文档相关refactor- 代码重构performance- 性能优化security- 安全相关llm-adapter- LLM 适配器ui/ux- 用户界面/体验config- 配置相关testing- 测试相关👥 审查者
建议的审查者：
📝 额外说明
感谢您的贡献！ 🎉
请确保您已经阅读并遵循了我们的 贡献指南。如果您有任何问题，请随时在 PR 中提问或联系维护者。