-
Notifications
You must be signed in to change notification settings - Fork 259
[SUGGESTION] Refactorings for to_cpp1.h file #1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Behavior should be exactly the same, to the notable exception of the value of |
Thanks for your pull request! It looks like this may be your first contribution to cppfront. I need to send you the Contributor License Agreement (CLA) but I don't have your email address -- please email me at first dot last at gmail. Once it's signed I can look at your pull request. Thanks again for your contribution. |
@hsutter email sent :) |
Signed-off-by: Alex Dutka <[email protected]>
Signed-off-by: Alex Dutka <[email protected]>
Signed-off-by: Alex Dutka <[email protected]>
It seems like something went wrong here, but I won't try to fix it without knowing first if this is something you are interested in... |
Seems like the problem has been fixed... |
Thanks! Sorry for the lag on this... Organization note: I want to keep the current file structure and not break I appreciate this but I don't have the cycles to review this now per the priorities in #1287, so for now I'll close this PR. (Sorry!) If there is a subset of this where you see direct duplication in |
This PR contains a handful of small helper extractions to simplify the
to_cpp1.h
file, which reduces its length by about 1000 lines. Indeed, this file is very long and I believe that there are a lot of low hanging fruits like these ones... What do you think about that?