Skip to content

[Suggestion] Add Ubuntu tests for GCC 14 and Clang 18 #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024

Conversation

jarzec
Copy link
Contributor

@jarzec jarzec commented May 22, 2024

Now that Ubuntu 24.04 LTS is out and a respective GitHub runner is already available it seems to make a lot of sense to add GCC 14 and Clang 18 to the test suite. Both compilers are installed by default on the ubuntu-24.04 GitHub runner.

With C++26 in sight it might also be the time to drop tests (not yet done in this PR):

  • on ubuntu-20.04,
  • for GCC 10,
  • for Clang 12.

Thoughts anyone?

@@ -19,13 +19,15 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04]
compiler: [g++-10, clang++-15]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is where GCC 10 support is removed? I'd like to keep it please (see longer comment in main thread).

Copy link
Contributor Author

@jarzec jarzec May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just changing the defaults. GCC 10 is kept on Ubuntu 20.04 in new lines 29 - 30. It might be possible to install that version on the newer Ubuntu, but I don't think there will be much difference in the test execution. I can check this, though.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Right you are, sorry. I didn't look at the rest of the changes carefully enough.

@hsutter
Copy link
Owner

hsutter commented May 22, 2024

Thanks! Quick check:

With C++26 in sight it might also be the time to drop tests (not yet done in this PR):

  • on ubuntu-20.04,
  • for GCC 10,
  • for Clang 12.

Actually this PR does remove GCC 10 for the regression tests, right?

I'd like to keep GCC 10 and Clang 12 as a baseline, because right now they do work (with only a few exceptions that should all have diagnostics), and I'd like to know when we come to the point where something in the code gen causes generated code to no longer be compatible with them. (FWIW, I do my own local testing with GCC 10 and 13, and Clang 12.)

@jarzec
Copy link
Contributor Author

jarzec commented May 22, 2024

Thanks! Quick check:

With C++26 in sight it might also be the time to drop tests (not yet done in this PR):

  • on ubuntu-20.04,
  • for GCC 10,
  • for Clang 12.

Actually this PR does remove GCC 10 for the regression tests, right?

I'd like to keep GCC 10 and Clang 12 as a baseline, because right now they do work (with only a few exceptions that should all have diagnostics), and I'd like to know when we come to the point where something in the code gen causes generated code to no longer be compatible with them. (FWIW, I do my own local testing with GCC 10 and 13, and Clang 12.)

As I mentioned in the earlier comment I did keep all the compilers used so far. You can confirm that in the list of checks (GCC 10 and Clang 12).

@hsutter
Copy link
Owner

hsutter commented May 23, 2024

Thanks! I overlooked it, sorry.

@hsutter hsutter merged commit 8cbc2a8 into hsutter:main May 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants