[CI] Regression test jobs now include the C++ standard version and (if applicable) the standard library to link with #1080
Conversation
…licable) the standard library to link with * Add a new job to test clang with libc++ on ubuntu. (All other ubuntu jobs for gcc & clang link with libstdc++.) * Add a new msvc job so that we now test `c++latest` and `c++20`. * Job names now include more information: <short os name> | <compiler> | <c++ std> | <std library> | <full os name> * Reorder jobs so that GCC are first, then clang on ubuntu & macOS, and then msvc on Windows e.g. ubu-24 | g++-14 | c++2b | libstdc++ | ubuntu-24.04 mac-13 | clang++ | c++2b | default | macos-13 win-22 | cl.exe | c++latest | default | windows-2022
There was a problem hiding this comment.
LGTM
Cool, thanks! I was thinking of adding std lib version but never had time.
BTW as usual https://github.com/hsutter/cppfront/pull/1080/files is not very responsive for big diffs and freezes after some time.
I suggest reviewing in VSCode through https://github.dev/hsutter/cppfront/pull/1080/files.
| REM cl /std:c++latest /EHsc /nologo /W4 /MD /c "%VCToolsInstallDir%\modules\std.ixx" | ||
| REM cl /std:c++latest /EHsc /nologo /W4 /MD /c "%VCToolsInstallDir%\modules\std.compat.ixx" | ||
| REM cl /std:c++20 /EHsc /nologo /W4 /MD /c "%VCToolsInstallDir%\modules\std.ixx" | ||
| REM cl /std:c++20 /EHsc /nologo /W4 /MD /c "%VCToolsInstallDir%\modules\std.compat.ixx" |
There was a problem hiding this comment.
I overlooked this change in my first review. It is OK with me, but @hsutter please confirm this is something you want. I guess you use this script a lot, don't you?
There was a problem hiding this comment.
That change is in the new msvc c++20 directory. The original bat file is unchanged but its directory now has c++latest in its name.
|
Thanks! Sounds like this has been reviewed and is all set to go. |
libc++on ubuntu. (All other ubuntu jobs for gcc & clang link withlibstdc++.)c++latestandc++20.Job names now have this format:
<short os name> | <compiler> | <c++ std> | <std library> | <full os name>The summary job list shows them like this (which unfortunately still crops the end):
Full name when you click into a job:
The
test-resultsdirectories now include the C++ standard and, only for libc++ on ubuntu, the standard library name.