This repository was archived by the owner on Apr 15, 2025. It is now read-only.
forked from opensciencegrid/stashcp
-
Notifications
You must be signed in to change notification settings - Fork 6
Adding OpenTelemetry tracing #41
Open
djw8605
wants to merge
12
commits into
htcondor:main
Choose a base branch
from
djw8605:trace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
reviewed
Feb 7, 2023
main.go
Outdated
@@ -219,6 +231,41 @@ func DoStashCPSingle(sourceFile string, destination string, methods []string, re | |||
} | |||
}() | |||
|
|||
exporter, err := otlptrace.New( | |||
context.Background(), | |||
otlptracehttp.NewClient(otlptracehttp.WithEndpoint("osdf-oltp.nrp-nautilus.io:443")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we register a osg-htc.org
hostname for this? I'm wary of leaking implementation hostnames into source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, this is very much a proof-of-concept pull request. The plan is to move it over to tiger, but yes, we will have an osg-htc hostname.
…es not affect download operation
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.