This repository was archived by the owner on Apr 15, 2025. It is now read-only.
Centralize the configuration of the OSDF client. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
force-pushed
the
centralize_config
branch
2 times, most recently
from
2ff3c1a to
1048542
Compare
|
@djw8605 - ping on this PR review. |
As we want to have the ability to stand up additional data federation instances (think: test directors), we should split out and centralize the defaults. This introduces the use of viper for the process-wide configuration management. This will allow the use of configuration files in the near future.
In some unit tests, we need to alter the configuration via env var (to ensure the environment-based changes are effective); this adds in re-initialization at the appropriate points. Additionally, this moves the various timeout constants to the config subsystem, allowing us to use much shorter timeouts for test runs (taking about 6 minutes off the time to run `go test`).
bbockelm
force-pushed
the
centralize_config
branch
from
1048542 to
6e4c6ca
Compare
Since the binary generated for namespaces_test.go doesn't start with `stash`, the override for the test should be `PELICAN`-prefixed instead.
bbockelm
force-pushed
the
centralize_config
branch
from
4fb67fe to
7f20d1a
Compare
|
I think I'm fine with saving the overhaul of the README for later... probably a few more things to land first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we want to have the ability to stand up additional data federation instances (think: test directors), we should split out and centralize the defaults.
This introduces the use of viper for the process-wide configuration management. This will allow the use of configuration files in the near future.