Skip to content

Fix to issue #1033 as proposed by @dkeeney #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fcr
Copy link
Collaborator

@fcr fcr commented Feb 9, 2025

No description provided.

Copy link

@dkeeney dkeeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@dkeeney
Copy link

dkeeney commented Feb 11, 2025

I was able to clone and checkout the "reset" branch on windows. I then did a full build and confirmed that the both C++ and Python unit tests ran.

I then setup Ubuntu on VirtualBox and cloned. But the "reset" branch was not there.
It appears that you checked in the PR via your fcr repository which my virtual box environment cannot access.
So, rather than try to unscramble that I will try to create a new PR directly on htm-community/htm.core.

@dkeeney
Copy link

dkeeney commented Feb 12, 2025

I am getting a build error on Ubuntu. Nothing to do with this PR, but googletest is not getting installed correctly during the build. Looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants