Skip to content

Stop setting container scrollTop to zero on render if collection has offset #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Stop setting container scrollTop to zero on render if collection has offset #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4625ddb
Add scroll test where a collection that is in the middle of the scrol…
gwak Dec 20, 2017
ffda3d1
Fix a syntax error in a failing measure test
gwak Dec 20, 2017
0e10693
Fix issue where container scrollTop is reset on after render if colle…
gwak Dec 20, 2017
63fab03
Commit package-lock.json
gwak Oct 8, 2018
8cf2b31
Merged upstream
gwak Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion addon/-private/data-view/radar/radar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,8 @@ export default class Radar {

const scrollDiff = this._calculateScrollDiff();

if (scrollDiff !== 0) {
// Reset the container scrolling position when the collection has no offset
if (scrollDiff !== 0 && this._collectionOffset === 0) {
this._scrollContainer.scrollTop += scrollDiff;
}

Expand Down
Loading