feat: extract passive metadata via CDP performance logs and request interception - #30
Merged
Merged
Conversation
…request interception
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
gildesmarais
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new helper function for passively extracting HTTP response metadata from browser automation drivers, and refactors the metadata fetching logic to use this passive approach before falling back to active network requests. Comprehensive tests are also added to ensure the new metadata extraction logic works as intended.
Metadata extraction improvements:
_extract_passive_metadatafunction toapp/main.pythat retrieves HTTP status code, headers, and URL from the driver's intercepted requests or browser performance logs, minimizing extra network calls._fetch_metadatainapp/main.pyto first attempt passive metadata extraction using the new helper, only falling back to active network requests if necessary.Testing enhancements:
_extract_passive_metadatatotests/test_api_contract.py, covering both extraction from a driver'srequestslist and from browser performance logs.