Нужно больше функций #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
ILokalin
reviewed
May 27, 2025
js/functions.js
Outdated
| const isLessOrEqual = (testString, amountSymbols) =>{ | ||
| if (testString.length <= amountSymbols){ | ||
| return true; | ||
| }else { |
There was a problem hiding this comment.
Не используем условия если результат ожидается boolen - возвращаем логическое выражение
return testString.length <= amountSymbols;
ILokalin
reviewed
May 27, 2025
js/functions.js
Outdated
|
|
||
| const isPalindrom = (text) =>{ | ||
| const unspacedText = text.replaceAll(' ', ''); | ||
| const normalizedText = unspacedText.toUpperCase(); |
There was a problem hiding this comment.
Полезно применить цепочку, так как нет необходимости в промежуточной константе
const normalizedText = text.replaceAll(' ', '').toUpperCase();
ILokalin
reviewed
May 27, 2025
js/functions.js
Outdated
| const unspacedText = text.replaceAll(' ', ''); | ||
| const normalizedText = unspacedText.toUpperCase(); | ||
| let reversedText = ''; | ||
| for (let lastIndex = normalizedText.length - 1; lastIndex >= 0 ; lastIndex --) { |
There was a problem hiding this comment.
- команды явного присвоения более удобные для чтения
длинная запись
lastIndex = lastIndex - 1
короткая, которая принята в общей практике
lastIndex -= 1
- название индекса
НазваниеlastIndeexсложно ассоциировать с реальным назначением. Фактически, это просто "индекс" - индексы в циклах принято называть односимвольными названиями, по порядку вложенности циклов:i,j,n,m
Т.е., если цикл основной или единственный - индекс всегда именуется i
ILokalin
reviewed
May 27, 2025
js/functions.js
Outdated
| for (let lastIndex = normalizedText.length - 1; lastIndex >= 0 ; lastIndex --) { | ||
| reversedText += normalizedText.at(lastIndex); | ||
| } | ||
| if(normalizedText === reversedText){ |
There was a problem hiding this comment.
Вернуть можно результат логического выражения - условие не требуется
Contributor
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Нужно больше функций
💥 https://htmlacademy-javascript.github.io/2607777-kekstagram-2/3/