Функции возвращаются #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
ILokalin
reviewed
Jun 17, 2025
js/functions.js
Outdated
| }; | ||
| const getTimeConv = (time) => { | ||
| const timelist = time.split(':'); | ||
| const finalResult = Number(timelist[0]) * 60 + Number(timelist[1]); |
There was a problem hiding this comment.
"финальный результат" - это очень абстрактно. Эта функция возвращает что очень конкретное, но название функции и результата скрывают это.
Что вернет функция?
ILokalin
reviewed
Jun 17, 2025
js/functions.js
Outdated
| const isWorkTime = (startDate, endDate, startMeet, durationMeet) =>{ | ||
| const duration = durationMeet + getTimeConv(startMeet); | ||
| if(getTimeConv(startDate) <= duration && duration <= getTimeConv(endDate)){ | ||
| return true; |
There was a problem hiding this comment.
если требуется вернуть логическое значение и для этого есть логическое выражение - возвращаем его результат
return getTimeConv(startDate) <= duration && duration <= getTimeConv(endDate);
ILokalin
reviewed
Jun 17, 2025
js/functions.js
Outdated
| //console.log(getTimeConv('00:01')); | ||
|
|
||
| const isWorkTime = (startDate, endDate, startMeet, durationMeet) =>{ | ||
| const duration = durationMeet + getTimeConv(startMeet); |
There was a problem hiding this comment.
скорее всего, это не "продолжительность". Начало встречи + продолжительность = окончание встречи (в минутах, так как выполнена конвертация)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Функции возвращаются
💥 https://htmlacademy-javascript.github.io/2607777-kekstagram-2/6/