Skip to content

fix: sanitize GET params and add null checks in REST API association endpoints #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thisismyurl wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: sanitize GET params and add null checks in REST API association endpoints #1317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions core/REST_API/Router.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,11 +321,15 @@ public function get_comment_meta( $data ) {
* @return array
*/
public function get_association_data() {
$container_id = $_GET['container_id'];
$field_id = $_GET['field_id'];
$options = isset( $_GET['options'] ) ? explode( ';', $_GET['options'] ) : array();
$container_id = isset( $_GET['container_id'] ) ? sanitize_text_field( $_GET['container_id'] ) : '';
$field_id = isset( $_GET['field_id'] ) ? sanitize_text_field( $_GET['field_id'] ) : '';
$options = isset( $_GET['options'] ) ? explode( ';', sanitize_text_field( $_GET['options'] ) ) : array();
Comment on lines +324 to +326
$return_value = array();

if ( ! $container_id || ! $field_id ) {
return $return_value;
}
Comment on lines +329 to +331

/** @var \Carbon_Fields\Field\Association_Field $field */
$field = Helper::get_field( null, $container_id, $field_id );

Expand Down Expand Up @@ -367,8 +371,12 @@ public function get_association_options() {
$page = isset( $_GET['page'] ) ? absint( $_GET['page'] ) : 1;
$term = isset( $_GET['term'] ) ? sanitize_text_field( $_GET['term'] ) : '';

$container_id = $_GET['container_id'];
$field_id = $_GET['field_id'];
$container_id = isset( $_GET['container_id'] ) ? sanitize_text_field( $_GET['container_id'] ) : '';
$field_id = isset( $_GET['field_id'] ) ? sanitize_text_field( $_GET['field_id'] ) : '';

if ( ! $container_id || ! $field_id ) {
return array();
}
Comment on lines +377 to +379

/** @var \Carbon_Fields\Field\Association_Field $field */
$field = Helper::get_field( null, $container_id, $field_id );
Expand Down