-
-
Notifications
You must be signed in to change notification settings - Fork 399
feat(attr-sorted): Sort data-* attributes at end. #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sorry for the unrelated failed test, I changed the rules docs pages earlier today from .md to .mdx... I'll fix the test to check there instead... As for your code, looks all good at a glance I think... the only thing I was unsure of the use the 'lambda attribute' term as I hadn't heard of that before... (other than Amazon's Web Service) but if you think that's the best way to describe it then I'm okay with that. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1591 +/- ##
==========================================
+ Coverage 96.99% 98.47% +1.48%
==========================================
Files 2 2
Lines 1628 1638 +10
Branches 335 349 +14
==========================================
+ Hits 1579 1613 +34
+ Misses 49 25 -24
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
I'm French and I think I misused the term lambda. The correct translation is: average, ordinary or regular. We could use the word regular. |
I renamed lambda to regular. |
merci beaucoup! I'll update the docs when we make the next release, possibly next week. thanks again! |
Short description of what this resolves
Fix #1588
Proposed changes
I've modified the attr-sorted rule to handle
data-*
attributes.